Home Download Buy Blog Forum Support

Build 2115 bug: folding code / prev & next view

Build 2115 bug: folding code / prev & next view

Postby ehamiter on Fri Sep 09, 2011 4:14 pm

The keybindings are duped for the new code folding (previously set to next/prev view). I edited my User key bindings to this, which fixes it:
Code: Select all
{ "keys": ["super+alt+["], "command": "fold" },
{ "keys": ["super+alt+]"], "command": "unfold" },
{ "keys": ["super+shift+["], "command": "prev_view" },
{ "keys": ["super+shift+]"], "command": "next_view" }
ehamiter
 
Posts: 67
Joined: Wed Apr 27, 2011 2:42 am

Re: Build 2115 bug: folding code / prev & next view

Postby colinsullivan on Fri Sep 09, 2011 8:57 pm

Whew. Yes this freaked me out for a few minutes there.

Clearly the JSON of the key bindings file is being validated when saved. Is there anyway to check to ensure that no two key bindings have a collision? Just a thought.
colinsullivan
 
Posts: 2
Joined: Fri Sep 09, 2011 8:52 pm

Re: Build 2115 bug: folding code / prev & next view

Postby alexrussell on Sat Sep 10, 2011 12:59 pm

I'd say it'd be a bit difficult to check for a collision, because the whole process is there on purpose to allow you to override the default ones with your own. That is to say that it's valid to have two things mapped to one keybinding (and scope/context, etc.) because the latter will override the former. This gives us the ability to override the default bindings with our own in the User directory.

Having said that, it might be possible to validate that a single keybindings file (as it is parsed before going into the master list) doesn't contain two entries for one keybinding. I guess that's for Jon to decide.
alexrussell
 
Posts: 74
Joined: Fri Jul 15, 2011 9:06 am


Return to Technical Support

Who is online

Users browsing this forum: Exabot [Bot], Google [Bot] and 14 guests