Home Download Buy Blog Forum Support

Package Control: A full-featured package manager

Re: Package Control: A full-featured package manager

Postby bizoo on Mon Sep 05, 2011 10:14 am

Small issue:
Code: Select all
class PanelPrinter():
  ...
  def __init__(self):
    ...
    self.window = sublime.active_window()

return None when ST2 start.

Code: Select all
startup, version: 2112 windows x64 channel: dev
...
Reloading plugin C:\Users\dwahli\AppData\Roaming\Sublime Text 2\Packages\ZenCoding\zenmeta.py
Reloading plugin C:\Users\dwahli\AppData\Roaming\Sublime Text 2\Packages\ZenCoding\zentrackers.py
Traceback (most recent call last):
  File ".\Package Control.py", line 1744, in <lambda>
  File ".\Package Control.py", line 1682, in __init__
  File ".\Package Control.py", line 1229, in __init__
  File ".\Package Control.py", line 661, in __init__
  File ".\Package Control.py", line 30, in get
  File ".\Package Control.py", line 36, in __init__
AttributeError: 'NoneType' object has no attribute 'get_output_panel'
loading bindings
loading pointer bindings
...
bizoo
 
Posts: 879
Joined: Wed Dec 08, 2010 6:53 am
Location: Switzerland

Re: Package Control: A full-featured package manager

Postby wbond on Mon Sep 05, 2011 12:11 pm

bizoo wrote:Small issue:
Code: Select all
class PanelPrinter():
  ...
  def __init__(self):
    ...
    self.window = sublime.active_window()

return None when ST2 start.

Code: Select all
startup, version: 2112 windows x64 channel: dev
...
Reloading plugin C:\Users\dwahli\AppData\Roaming\Sublime Text 2\Packages\ZenCoding\zenmeta.py
Reloading plugin C:\Users\dwahli\AppData\Roaming\Sublime Text 2\Packages\ZenCoding\zentrackers.py
Traceback (most recent call last):
  File ".\Package Control.py", line 1744, in <lambda>
  File ".\Package Control.py", line 1682, in __init__
  File ".\Package Control.py", line 1229, in __init__
  File ".\Package Control.py", line 661, in __init__
  File ".\Package Control.py", line 30, in get
  File ".\Package Control.py", line 36, in __init__
AttributeError: 'NoneType' object has no attribute 'get_output_panel'
loading bindings
loading pointer bindings
...


Yes, it appears there is a startup issue that I did not catch. It seems to happen sometimes on Windows and pretty much every time on OS X. Version 1.2.2 should fix it.
wbond
 
Posts: 527
Joined: Mon Feb 28, 2011 5:33 am

Re: Package Control: A full-featured package manager

Postby wbond on Mon Sep 05, 2011 1:46 pm

sublimator wrote:I tried to upgrade PackageControl via itself but get Putty errors when it does the `Loading Repositories [= ]`

Image

"version": "1.2.1"

I clicked OK twice. Sublime went all white and crashed.

What's it doing that needs putty out of curiosity?


That would indicate that you cloned a git or hg repository into the Packages directory via TortoiseGit or TortoiseHg. That, or at least Package Control found a git or hg repository and also found TortoiseGit or TortoiseHg and was trying to use them to fetch the remote repository information.

I did just release version 1.2.2 of Package Control to fix a startup bug in 1.2.1 that was causing crashing on some machines.
wbond
 
Posts: 527
Joined: Mon Feb 28, 2011 5:33 am

Re: Package Control: A full-featured package manager

Postby bizoo on Tue Sep 06, 2011 5:51 am

I have a crash with this scenario:
  • Execute the "Package Control: Install Package" command.
  • Switch to another windows before the end of the command.
  • Wait a few seconds.
  • Crash of ST2
It's always reproducible.
If I minimize ST2 instead of put it's windows on the background, it works fine.

startup, version: 2112 windows x64 channel: dev
bizoo
 
Posts: 879
Joined: Wed Dec 08, 2010 6:53 am
Location: Switzerland

Re: Package Control: A full-featured package manager

Postby wbond on Tue Sep 06, 2011 12:46 pm

bizoo wrote:I have a crash with this scenario:
  • Execute the "Package Control: Install Package" command.
  • Switch to another windows before the end of the command.
  • Wait a few seconds.
  • Crash of ST2
It's always reproducible.
If I minimize ST2 instead of put it's windows on the background, it works fine.

startup, version: 2112 windows x64 channel: dev


I've tried a bunch of times to reproduce this, but I've been unable. What other plugins do you have installed?

What program are you switching too? I've tried switching to another Sublime window, Windows explorer and Chrome.

What package are you trying to install when this happens?

Do you have an antivirus program installed? Again, I'm just trying to figure out how your machine is different than mine.

And lastly, do you have any packages cloned via git or hg in your Packages directory?
wbond
 
Posts: 527
Joined: Mon Feb 28, 2011 5:33 am

Re: Package Control: A full-featured package manager

Postby wbond on Tue Sep 06, 2011 12:49 pm

sublimator wrote:I adjusted the downloader to group the downloads by domain and then schedule/stagger them in 250ms increments rather than do them serially. It seems to load a lot faster.


They should already be grouped by domain (https://github.com/wbond/sublime_packag ... ol.py#L759), but you are saying you added a timeout between each download also? Could you throw a gist up of what you've changed?
wbond
 
Posts: 527
Joined: Mon Feb 28, 2011 5:33 am

Re: Package Control: A full-featured package manager

Postby wbond on Tue Sep 06, 2011 12:59 pm

sublimator wrote:Anyway, once the repo list gets to grow, it might be worth looking at pushing some of the work to a server with a cache so you can do everything with one request from Sublime.


Yeah, that is on my list of things to do.
wbond
 
Posts: 527
Joined: Mon Feb 28, 2011 5:33 am

Re: Package Control: A full-featured package manager

Postby wbond on Tue Sep 06, 2011 1:10 pm

sublimator wrote:I don't know what'd be the best way to stagger them (likely not set_timeout) but any issues with mass parallelism seem to be alleviated with some stagger.


Thanks for the code. I'll run it through some testing on my various environments and then push it out to see if it alleviates issues for the windows users that have been having crashes.
wbond
 
Posts: 527
Joined: Mon Feb 28, 2011 5:33 am

Re: Package Control: A full-featured package manager

Postby wbond on Tue Sep 06, 2011 6:52 pm

sublimator wrote:I pushed some experimental alterations for your consideration: https://github.com/sublimator/sublime_p ... ol.py#L797

100ms staggering between the requests seems to work for me.

I've loaded bitbucket pages firebug before and seem them use the api a lot, sometimes 4-5 ajax requests.


I tried out the grouping you had but it is now taking around twice as long to bring up the package list and I am getting multiple retries every time. I think the extra time might be because you a joining on the first running downloader you hit.

I'm going to try and get my windows install in a situation where I have an error trying to get something from bitbucket or github and see if I can replicate the crashing. After that I an ensure there is a fix that works.
wbond
 
Posts: 527
Joined: Mon Feb 28, 2011 5:33 am

Re: Package Control: A full-featured package manager

Postby wbond on Tue Sep 06, 2011 8:45 pm

bizoo wrote:I have a crash with this scenario:
  • Execute the "Package Control: Install Package" command.
  • Switch to another windows before the end of the command.
  • Wait a few seconds.
  • Crash of ST2
It's always reproducible.
If I minimize ST2 instead of put it's windows on the background, it works fine.

startup, version: 2112 windows x64 channel: dev


I was finally able to reproduce this. It appears that creating a hidden window subprocess for hg from within a thread in ST2 is causing the crash. I am guessing this is an issue with ST2, so I am going to see if I can provide Jon with enough information to look into it.
wbond
 
Posts: 527
Joined: Mon Feb 28, 2011 5:33 am

PreviousNext

Return to Plugin Announcements

Who is online

Users browsing this forum: Google [Bot] and 9 guests