Home Download Buy Blog Forum Support

BracketHighlighter2 BETA Branch

Re: BracketHighlighter2 Alpha Branch

Postby facelessuser on Fri Oct 26, 2012 3:52 pm

I admit, I am a bit surprised that that was the first real bug discovered; I expected more :D.

As for a bad settings file causing BH to stop, I will try and put in a catch to keep it from exiting the script. I will see if I can keep the BH thread functional. Worse case scenario, I can add a restart command to start it again.
facelessuser
 
Posts: 1567
Joined: Tue Apr 05, 2011 7:38 pm

Re: BracketHighlighter2 Alpha Branch

Postby facelessuser on Fri Oct 26, 2012 3:58 pm

@iamntz
What kind of settings errors were you talking about. Before I approach this, I want to make sure I understand what kind bad settings issues I should be looking into.
facelessuser
 
Posts: 1567
Joined: Tue Apr 05, 2011 7:38 pm

Re: BracketHighlighter2 Alpha Branch

Postby iamntz on Fri Oct 26, 2012 5:12 pm

Well, not sure. When i tried different patterns on that if/endif thing i noticed that a bad regex will stop highlight everywhere. The thing is i can't reproduce it, it's some kind of Lance Armstrong bug :D

I'll let you know if i will figure out.
iamntz
 
Posts: 908
Joined: Fri Apr 29, 2011 8:52 am
Location: Romania

Re: BracketHighlighter2 Alpha Branch

Postby facelessuser on Fri Oct 26, 2012 5:37 pm

No biggie, just let me know if/when you can pinpoint it.

I haven't spent much time hardening the plugin against bad settings inputs yet. This is because I haven't finalized the settings file yet. If/when I separate style stuff from bracket definitions, it will probably change a lot of stuff.

As I get closer to a beta, hopefully a lot of that will get cleared up.
facelessuser
 
Posts: 1567
Joined: Tue Apr 05, 2011 7:38 pm

Re: BracketHighlighter2 Alpha Branch

Postby Eduan on Fri Oct 26, 2012 7:27 pm

This is awesome Isaac! I think this is getting to the point where it is no longer alpha. :)

Just wanted to ask a question though, I haven't installed this package so don't know exactly how it works.

But from what I've seen in the images, even a single curly bracket ( { ) will put a two brackets image ( {} ) in the left. Is this updated so that it only shows one, meaning the closing one or the opening one, or both if it applies.
Check out my blog and website: EduanTech.com (currently undergoing some facial and organs makeover...)
Also check out my profiles: GitHub - Greduan | BitBucket - Greduan
Eduan
 
Posts: 140
Joined: Sun Oct 14, 2012 4:05 pm

Re: BracketHighlighter2 Alpha Branch

Postby facelessuser on Fri Oct 26, 2012 7:52 pm

Picture is worth 1000 words:

brackets.png
brackets.png (3.52 KiB) Viewed 1070 times
facelessuser
 
Posts: 1567
Joined: Tue Apr 05, 2011 7:38 pm

Re: BracketHighlighter2 Alpha Branch

Postby Eduan on Fri Oct 26, 2012 8:39 pm

OK I see how that works, could you modify it so that it shows the opening tag, closing tag, or both depending on which one is found? Or would it be too much? Just cause I think it would really make things clearer. :)

- Eduan

EDIT: I did not read the text, lol. That's awesome, glad it works, just gotta add the correct icons then?
Check out my blog and website: EduanTech.com (currently undergoing some facial and organs makeover...)
Also check out my profiles: GitHub - Greduan | BitBucket - Greduan
Eduan
 
Posts: 140
Joined: Sun Oct 14, 2012 4:05 pm

Re: BracketHighlighter2 Alpha Branch

Postby facelessuser on Fri Oct 26, 2012 8:44 pm

In order to do that I need icons.

currently I have:
icon.png
icon_small.png

To do what you want for a particular bracket I need (brackets that do not want to show open and close could omit the open and close):
icon.png
icon_open.png
icon_close.png
icon_small.png
icon_open_small.png
icon_close_small.png

I am not a fan of making lots of tiny icons and trying to position them just right. But I will make everyone a deal. If someone provides all the icons all lined up nice and with the size variants, I will add the functionality :D. Deal?
facelessuser
 
Posts: 1567
Joined: Tue Apr 05, 2011 7:38 pm

Re: BracketHighlighter2 Alpha Branch

Postby Eduan on Fri Oct 26, 2012 9:07 pm

Deal! So what do you want me to do? Just center them and make them small when the image is small?
Check out my blog and website: EduanTech.com (currently undergoing some facial and organs makeover...)
Also check out my profiles: GitHub - Greduan | BitBucket - Greduan
Eduan
 
Posts: 140
Joined: Sun Oct 14, 2012 4:05 pm

Re: BracketHighlighter2 Alpha Branch

Postby facelessuser on Fri Oct 26, 2012 9:19 pm

Eduan wrote:Deal! So what do you want me to do? Just center them and make them small when the image is small?

Kind of, but not quite.

- Icons are 16X16 regardless if they are big or small.
- The icons need to be white with transparent backgrounds so that when they get masked they are the correct color.
- They need to all be relatively lined up and look appropriate aligned in the gutter. So if the curly icon is centered in the gutter, and the round looks like it is left justified, it is jarring. They all need to roughly be centered/aligned the same.
- Small icons are the same size png as the large, but you have to shrink the actual icon in roughly in the upper left quadrant. If someone made a template that had a layers with guides to optimally place the icons that are big or small, that would help.
- Next you need open and close and normal (both opening and closing) for the icons that make sense. And you need small variants of all three.
- Follow the naming convention shown above.

Icons like "dot" etc, that don't make sense having opening and closing can omit the open and close variants.

That is it. If you do that, I will add the support. Currently I show show the same icon on closing and opening, and if any bracket cannot be matched, I show the same invalid icon. Do not worry about invalid icons, I am leaving that generic. If you come up with a better invalid, that is great.
facelessuser
 
Posts: 1567
Joined: Tue Apr 05, 2011 7:38 pm

PreviousNext

Return to Plugin Announcements

Who is online

Users browsing this forum: No registered users and 7 guests