Home Download Buy Blog Forum Support

Soda Theme - New Sublime Text 2 UI theme

Re: Soda Theme - New Sublime Text 2 UI theme

Postby buymeasoda on Tue Jul 26, 2011 12:33 pm

ekolguy wrote:Yes it is, latest dv build and up-to-date theme from github.


I think I'll be removing the show close button display on hover, in favour of matching what the latest dev builds have. Which is: If show tabs is on the tabs always show and if show tabs if off, they never show. That what you were hoping for in terms of behaviour?
buymeasoda
 
Posts: 65
Joined: Mon Jul 18, 2011 11:40 pm
Location: Brisbane, Australia

Re: Soda Theme - New Sublime Text 2 UI theme

Postby ldhughes on Tue Jul 26, 2011 12:59 pm

I really like your Soda Dark theme. I of course like to tweak thing so might I suggest that you move the Theme - Soda folder out of the User folder and place in in the main Packages folder. This way a user could create a Soda Dark.sublime-theme file in their User folder to allow overriding some of the setting without needing to changing the original file. This was what I was doing with the Default theme.

Another option would be to move all themes into a Packages/Themes folder and that would contain all themes where the *.sublime-theme files would be in the Themes folder and all graphics would be in the Theme_Name folders, i.e. Default\, Soda Dark\ etc. One of the drawbacks I see with the approach is version control of separate theme packages would be difficult.

Dan
ldhughes
 
Posts: 6
Joined: Thu May 19, 2011 3:00 pm

Re: Soda Theme - New Sublime Text 2 UI theme

Postby buymeasoda on Tue Jul 26, 2011 1:30 pm

ldhughes wrote:I suggest that you move the Theme - Soda folder out of the User folder and place in in the main Packages folder.


I think you're right, that /Packages is probably the better choice rather than /Packages/User. And if that setup lets you have convenient access to overriding any of the theme settings easily then it makes even more sense.

I took a gamble on my interpretation of what the "User" folder might be for, and from some of the discussions I've had, it looks like it's more for the individual users customisation, rather than general, third party / non-core (aka not shipped by default) customisations.

There were a few points raised over on the GitHub page about it: https://github.com/buymeasoda/soda-theme/issues/10

Perhaps Jon, you'd be able to confirm, should the theme be moved to /Packages? Is that the preferred location for things like a UI theme?

Suggestion: One of the ideas for circumventing pathing issues with theme assets could be to path from the theme file location down relatively, rather than making paths relative to the fixed /Packages starting point (more details on the github issues page). Then it wouldn't matter if the theme was placed directly in /Packages, or /Packages/User as the assets would always be referencable.
buymeasoda
 
Posts: 65
Joined: Mon Jul 18, 2011 11:40 pm
Location: Brisbane, Australia

Re: Soda Theme - New Sublime Text 2 UI theme

Postby jps on Tue Jul 26, 2011 2:02 pm

User isn't the right place, I'd suggest making a package called 'Theme - Soda', with two files in it, 'Soda Light.sublime-theme' and 'Soda Dark.sublime-theme': basically what you've got now, but in a package of its own, rather than under User.

Theme relative paths are a little bit tricky. Themes themselves don't naturally have a path - when loading, all files across all packages named 'Soda Light.sublime-theme' are loaded and merged, and the result used for the theme. It would be reasonable to preprocess the data though, perhaps replacing '$package' in strings with the package of the file in question before the merging step.
jps
Site Admin
 
Posts: 3067
Joined: Wed Mar 19, 2008 12:33 pm

Re: Soda Theme - New Sublime Text 2 UI theme

Postby Anomareh on Tue Jul 26, 2011 4:09 pm

The new dark updates are lovely! I think there are only 2 things left sort of bugging me.

  • I think the scrollbar track could use the same treatment the status bar got (which is perfect now btw!).
  • Not sure if it's just on my end but text labels everywhere seem to be 1-2px above being vertically centered. Namely the panel buttons (find, replace, etc.), status bar, and selected files / folders in the side panel. (Linux, Arch, x86_64) Can take some screenshots if you'd like.
Keep up the great work.
Last edited by Anomareh on Tue Jul 26, 2011 4:19 pm, edited 1 time in total.
Anomareh
 
Posts: 222
Joined: Thu Oct 01, 2009 7:32 pm

Re: Soda Theme - New Sublime Text 2 UI theme

Postby capnhud on Tue Jul 26, 2011 4:13 pm

Soda Dark is really pleasing the to the eye Nice Job
capnhud
 
Posts: 62
Joined: Thu Jan 14, 2010 11:57 am

Re: Soda Theme - New Sublime Text 2 UI theme

Postby Kronuz on Tue Jul 26, 2011 4:18 pm

Really, do you think panels could be just a bit darker in "Soda Dark"? ...I wish they were, they're a bit too light for my taste :S

(Just a bit, to match the status bar tone)
Kronuz
 
Posts: 98
Joined: Mon Feb 14, 2011 3:14 pm

Re: Soda Theme - New Sublime Text 2 UI theme

Postby ekolguy on Tue Jul 26, 2011 8:41 pm

buymeasoda wrote:I think I'll be removing the show close button display on hover, in favour of matching what the latest dev builds have. Which is: If show tabs is on the tabs always show and if show tabs if off, they never show. That what you were hoping for in terms of behaviour?


Actually it doesn't matter as long as I can turn of close buttons completely. I keep hitting them by accident when using mouse.
ekolguy
 
Posts: 41
Joined: Thu Dec 17, 2009 8:50 am

Re: Soda Theme - New Sublime Text 2 UI theme

Postby buymeasoda on Wed Jul 27, 2011 1:48 am

ekolguy wrote:Actually it doesn't matter as long as I can turn off close buttons completely. I keep hitting them by accident when using mouse.


Cool. If you update to the latest version, and have your "show_tab_close_buttons" set to false, you won't ever see the close buttons now, hover or otherwise.
buymeasoda
 
Posts: 65
Joined: Mon Jul 18, 2011 11:40 pm
Location: Brisbane, Australia

Re: Soda Theme - New Sublime Text 2 UI theme

Postby buymeasoda on Wed Jul 27, 2011 3:02 am

jps wrote:User isn't the right place, I'd suggest making a package called 'Theme - Soda'


Ok, good to know. I'll look at making the change to move it to /Packages. Will update here when that happens, and via the github page as people who git cloned the theme will get broken image references until they relocate their theme folder from inside /Packages/User. That'll be fun ;)
buymeasoda
 
Posts: 65
Joined: Mon Jul 18, 2011 11:40 pm
Location: Brisbane, Australia

PreviousNext

Return to General Discussion

Who is online

Users browsing this forum: Google [Bot], macula, Makenson, Yahoo [Bot] and 29 guests