Home Download Buy Blog Forum Support

Origami: Pane traversal, creation, and destruction

Re: Origami: Pane traversal, creation, and destruction

Postby jps on Wed Jun 27, 2012 3:22 pm

Very nice! If you made it a WindowCommand, rather than a TextCommand, then it'd work in panes that don't have any files. Currently, if you create a pane, and then focus it immediately, you aren't able to move back.
On the nitpicky side of things, there's a few print statements still in the code, and your readme still mentions the old name :)

Edit: Apparently I'm foolish, and was looking at the wrong repo
jps
Site Admin
 
Posts: 3071
Joined: Wed Mar 19, 2008 12:33 pm

Re: Origami: Pane traversal, creation, and destruction

Postby Phunky on Wed Jun 27, 2012 3:58 pm

Awesome plugin :) I have a few requests;

1. Carry and Create would be awesome
2. Destroy and move current tabs to new panel
3. GoTo support
4. Save as layout? So you can go to a new project and just enable a certain layout?

Seriously though this is brill :)
Phunky
 
Posts: 35
Joined: Mon Feb 07, 2011 5:02 pm

Re: Origami: Pane traversal, creation, and destruction

Postby bizoo on Wed Jun 27, 2012 4:14 pm

jps wrote:Very nice! If you made it a WindowCommand, rather than a TextCommand, then it'd work in panes that don't have any files. Currently, if you create a pane, and then focus it immediately, you aren't able to move back.
On the nitpicky side of things, there's a few print statements still in the code, and your readme still mentions the old name :)

Edit: Apparently I'm foolish, and was looking at the wrong repo

Not so foolish, except for the readme, it looks you're right ;)
bizoo
 
Posts: 886
Joined: Wed Dec 08, 2010 6:53 am
Location: Switzerland

Re: Origami: Pane traversal, creation, and destruction

Postby adzenith on Wed Jun 27, 2012 5:43 pm

jps wrote:Very nice! If you made it a WindowCommand, rather than a TextCommand, then it'd work in panes that don't have any files. Currently, if you create a pane, and then focus it immediately, you aren't able to move back.
On the nitpicky side of things, there's a few print statements still in the code, and your readme still mentions the old name :)

Edit: Apparently I'm foolish, and was looking at the wrong repo

Luckily those two things have just been fixed! (by a pull request from someone else!) And I think I'm just gonna delete the old repo.
Thanks!
adzenith
 
Posts: 1217
Joined: Mon Oct 19, 2009 9:12 pm

Re: Origami: Pane traversal, creation, and destruction

Postby adzenith on Wed Jun 27, 2012 5:47 pm

Phunky wrote:Awesome plugin :) I have a few requests;

1. Carry and Create would be awesome
2. Destroy and move current tabs to new panel
3. GoTo support
4. Save as layout? So you can go to a new project and just enable a certain layout?

Seriously though this is brill :)


1. I'm pretty certain you can chain commands in keybindings (or was that only in Sublime Text 1?). If not, a carry+create could be added.
2. Can you describe this in more detail? Are you saying when you destroy a pane you want all the tabs in it to go to the newly-focussed pane?
3. Do you want the commands to show up in the command palette?
4. Save as layout could be pretty awesome. It also would be really easy... lemme see what I can do.
adzenith
 
Posts: 1217
Joined: Mon Oct 19, 2009 9:12 pm

Re: Origami: Pane traversal, creation, and destruction

Postby Phunky on Thu Jun 28, 2012 9:53 am

adzenith wrote:1. I'm pretty certain you can chain commands in keybindings (or was that only in Sublime Text 1?). If not, a carry+create could be added.


Didn't know about chaining keybindings i'll take a look at that :)

adzenith wrote:2. Can you describe this in more detail? Are you saying when you destroy a pane you want all the tabs in it to go to the newly-focussed pane?


Lets says you have one pane open with two tabs (HTML & CSS), we then create a new pane and move the CSS file over to it so we can compare HTML & CSS. I then wish to go back to a single pane but keep all files open, so I would like to destroy the selected pane while moving its files to the last active one.

adzenith wrote:3. Do you want the commands to show up in the command palette?


Yep!

adzenith wrote:4. Save as layout could be pretty awesome. It also would be really easy... lemme see what I can do.


Awesome :D
Phunky
 
Posts: 35
Joined: Mon Feb 07, 2011 5:02 pm

Re: Origami: Pane traversal, creation, and destruction

Postby bizoo on Thu Jun 28, 2012 11:04 am

Phunky wrote:Lets says you have one pane open with two tabs (HTML & CSS), we then create a new pane and move the CSS file over to it so we can compare HTML & CSS. I then wish to go back to a single pane but keep all files open, so I would like to destroy the selected pane while moving its files to the last active one.

Isn't it how it works currently ?
Closing a pane never close the files it contains, ST2 move it to another pane. I don't know if it is the last active one or the previous one.
bizoo
 
Posts: 886
Joined: Wed Dec 08, 2010 6:53 am
Location: Switzerland

Re: Origami: Pane traversal, creation, and destruction

Postby sublimator on Thu Jun 28, 2012 3:08 pm

Sounds like he wants a command that will close the pane of the active view, rather than one in a specifiable direction from it.
It is better to remain silent and be thought a fool, than to speak out and remove all doubt
sublimator
 
Posts: 649
Joined: Thu Mar 20, 2008 5:41 am

Re: Origami: Pane traversal, creation, and destruction

Postby adzenith on Fri Jun 29, 2012 9:12 pm

castles_made_of_sand wrote:Sounds like he wants a command that will close the pane of the active view, rather than one in a specifiable direction from it.

Oh, I see. This is actually more difficult because if you have more than two panes, where do you and your files end up? That's why you can only destroy a different pane. If you've got two panes, just destroy the other one and everything should work...?
adzenith
 
Posts: 1217
Joined: Mon Oct 19, 2009 9:12 pm

Re: Origami: Pane traversal, creation, and destruction

Postby sublimator on Sat Jun 30, 2012 3:53 am

>>> where do you and your files end up?

Phunky wrote:Destroy and move current tabs to new panel


I think you'd still key in a direction, it would just mean destroy current pane, move in the direction specified, drag the views, making the currently active view active in the group dragged to.
It is better to remain silent and be thought a fool, than to speak out and remove all doubt
sublimator
 
Posts: 649
Joined: Thu Mar 20, 2008 5:41 am

PreviousNext

Return to Plugin Announcements

Who is online

Users browsing this forum: Cacodaimon, Google [Bot] and 9 guests