Hi, Jon. I have a few points;
First, I like the new panel. It seems more coherent to collapse them into one. I only ever used incremental search anyway. I also like the visual style of the outlines; itās nice to see whatās coming. Is it possible to change the colours here? They are a little hard to see with my colour scheme and Iād like to highlight them a little more. The tmTheme files support a customisable āselectionā property, like this
<dict>
<key>settings</key>
<dict>
<key>selection</key>
<string>#0000dddd</string>
</dict>
</dict>
Is there one for these āpre-foundā regions?
Second, Iāve got ctrl+i burned into my brain now, though, and itās the same mapping I use in Visual Studio, so Iām trying to re-establish the the old mappings. Iām almost there, but havenāt found the perfect match yet. For those who want to copy, this seems to be working pretty well for me;
<binding key="ctrl+i" command="showPanel find"/>
<binding key="ctrl+i" command="findUnder">
<context name="isPanelVisible" value="true"/>
</binding>
Only problem is the āisPanelVisibleā context seems a bit broad, and will work if youāve got, say, the replace panel open. The context
<context name="option" value="isFindWidget"/>
Doesnāt work as I expected, because when you do the find, the focus moves into the main window and I think the isFindWidget option is set to false; this means that hitting ctrl+i over and over does this;
find window/next match/find window/next match
rather than
find window/next match/next match/next match
Third, Iām guessing the find/replace panel is going to be updated to be incremental too? The ability to see whatās going to get found/replaced would be really nice.
Lastly, (I promise,) is the question of what appears in the panel when you open it. The current behaviour seems to be to fill it with the current selection. I donāt know if itās always been like that, but thinking about it now I wonder if it might be nicer to leave it with whatever it had in there last time. Itās worth noting that when I have a regex in the box (say, ālā¦ā) and that happens to have selected the word ālikeā, when I re-open the panel it is now searching for the literal ālikeā and not my original pattern ālā¦ā. This can destroy possibly hard-crafted patterns, so Iād prefer that panel to keep whatever content it had before.
Thatāll teach you to ask for feedback.