"Smart" horizontal cursor positioning

[adzenith]

I was going to report a bug, but then it was already fixed by that "small modification" you made. Thanks!

[jps]

Bizoo, you may be able to implement this is a cleaner way using the xpos attribute of selection regions. If it's not -1 when the caret is moved down a row, then it specifies the column (in layout coords) for the caret to be placed in.

You can see it in action by pressing end and then down: the caret will be maintained at EOL. Currently, it automatically set to -1 whenever the buffer is edited, so you'd need to find appropriate places to get and set the value.

[bizoo]

Didn't know about xpos, thanks for the heads-up.

But I don't understand exactly what to do with it:
xpos() give me the 'expected' position for the cursor, but I don't think there's a way to set the xpos(), am I wrong ?

With my current implementation, I set the caret horizontal position before executing the move command.
This way the navigation are still managed by ST2 and work fine even if the next line (when move down) is smaller than the current caret position (so the xpos is correct out of the box).
The only problem is when you need the caret beyond the end of line, so when I need to set xpos.

If xpos is a read-only value, I don't see any uses for this plugin (but could be useful for others).
Am I missing something ???

[jps]

You can set the xpos by passing a 3rd argument to the Region constructor: sublime.Region(a, b, xpos)

[bizoo]

Yeah ! Thanks for the helping hand John.

It looks like everything works fine now.
Maybe there's still something to do to simplify the code, but I have no time right now to dig further... Maybe later.

Actually, I seriously think to replace the standard up/down cursor with these ones. But maybe jps already thought about putting something similar in the core ST2

Grab it at https://github.com/bizoo/SmartCursor and give it a try.

[adzenith]

For what it's worth, I've replaced the standard up and down arrows with this. I did this:

Code: Select all

  { "keys": ["up"], "command": "smart_cursor", "args": {"cmd": "move", "by": "lines", "forward": false}, "context":
    [
      { "key": "auto_complete_visible", "operator": "equal", "operand": false }
    ]
  },
  { "keys": ["down"], "command": "smart_cursor", "args": {"cmd": "move", "by": "lines", "forward": true}, "context":
    [
      { "key": "auto_complete_visible", "operator": "equal", "operand": false }
    ]
  },


[bizoo]

Thanks adzenith for the keybindings, will replace the examples from github with these ones.
I've just added it to my keybindings !

[facelessuser]

This sounds cool. I need to give this a try.

[bizoo]

Updated github right now with the new keybindings from adzenith and the fixes for the only issues I've found after a day of work:
-After selecting a text from right to left and delete/modify it, caret must be placed to the starting point of the selection (so, technically, always sel.a and not sel.begin()).
-Move down after an edit at the last line of the file move the caret horizontally but, of course, not vertically, which is IMHO not what users are expecting.

[bizoo]

For what it's worth, I've replaced the standard up and down arrows with this. I did this:

Code: Select all

  { "keys": ["up"], "command": "smart_cursor", "args": {"cmd": "move", "by": "lines", "forward": false}, "context":
    [
      { "key": "auto_complete_visible", "operator": "equal", "operand": false }
    ]
  },
  { "keys": ["down"], "command": "smart_cursor", "args": {"cmd": "move", "by": "lines", "forward": true}, "context":
    [
      { "key": "auto_complete_visible", "operator": "equal", "operand": false }
    ]
  },


@adzenith:
I used these keymaps but found a small issue:
When you go at the end of the auto complete list, press one more down close the auto complete and execute a move down command, not a smart_cursor down command.
If I remove the context, it works as expected.

Did you find an issue with enabling the smart_cursor for auto complete or did you add context 'in case of' ?
Thanks for your reply.