Home Download Buy Blog Forum Support

ST3: FuzzyFileNav

Re: ST3: FuzzyFileNav

Postby facelessuser on Fri Feb 22, 2013 7:54 pm

I will take a look at this. I don't think I meant it to work that way...
facelessuser
 
Posts: 1575
Joined: Tue Apr 05, 2011 7:38 pm

Re: ST3: FuzzyFileNav

Postby jsc on Fri Feb 22, 2013 8:51 pm

Obviously, you know your own code better than I do, but just in case it might save you some time digging, I believe the issue is in line 694 of fuzzy_file_nav.py. Togging with super+h toggles ignore_excludes, but it does not impact show_hidden. There seems to be some unintended overlap between the meaning of "excluded" files (by regexp) and "hidden" files.

I'm not sure what the right resolution is. I want to be able to change showing and hiding all files, hidden and excluded, through toggle, but there doesn't seem to be a clean way of doing it with just one toggle. Maybe keep super+h for toggling hide files and have another command to toggle excluded files? Or if it is easier, just change super+h to toggle show_hidden instead of ignore_excludes, since it is probably much rarer to want to load an excluded file than a hidden one.
jsc
 
Posts: 23
Joined: Wed Feb 20, 2013 2:24 am

Re: ST3: FuzzyFileNav

Postby facelessuser on Fri Feb 22, 2013 9:22 pm

@jsc I think you should be happy with the recent change. The behavior for the toggling of hidden files is more consistent now. Not sure what my original reason was for doing it the way I was, but you should have no issues now.

So what this means is when a new FuzzyPanel session is opened, it will use the setting in you setting file, then any time during the session you can toggle back and forth and it will remember the state throughout that session (until quick panel session is officially exited/completed). Regex excluded files and hidden are now treated the same.

I will backport this to ST2 later.
facelessuser
 
Posts: 1575
Joined: Tue Apr 05, 2011 7:38 pm

Re: ST3: FuzzyFileNav

Postby jsc on Sat Feb 23, 2013 5:12 am

So, a few things. Trying to let Package Control automatically upgrade caused another corrupted mess that wouldn't load. Whatever, I'll manually pull updates until that's fixed, probably a Package Control issue.

Secondly, your latest update, while having the admirable effect of allowing hidden file toggling no matter the initial setting of show_system_hidden_files, also has the side effect of ignoring the setting of show_system_hidden_files. I have tried it set to both true and false, and it always shows me hidden (and excluded) files on initial open.

Actually, now on more testing, that's not exactly true. 1) I have it set to false, always shows hidden files; 2) I set it to true, still shows me hidden files; 3) I set it back to false, and now it works like I expect. Oh wait, now it's back to showing me hidden files, although I haven't changed anything. So it's a bit hard to make it stick.

I think a sensible behavior might be to treat and excluded files exactly the same. That is, excluded files are just hidden files that were hidden by the user. Then use the hidden files setting to determine whether to open showing all files or just non-hidden ones.
jsc
 
Posts: 23
Joined: Wed Feb 20, 2013 2:24 am

Re: ST3: FuzzyFileNav

Postby facelessuser on Sat Feb 23, 2013 5:37 am

I had the logic backwards. It should be fixed now.

Whatever you have your settings file set to is the default when you open the fuzzy panel. You can toggle between hidden and not hidden during your session but when you have completed your action(s) and closed the panel, it is done. Next time you open a panel, it will use the default.

I am not sure what your other issues are...are you still having them now, if so, please explain because I don't think I understand.
facelessuser
 
Posts: 1575
Joined: Tue Apr 05, 2011 7:38 pm

Re: ST3: FuzzyFileNav

Postby jsc on Sat Feb 23, 2013 6:24 am

That fixed it! Thanks. Works fine.
jsc
 
Posts: 23
Joined: Wed Feb 20, 2013 2:24 am

Re: ST3: FuzzyFileNav

Postby jsc on Sun Feb 24, 2013 10:18 pm

I'm seeing this behavior where I lose the edit cursor and focus when I open a file using FFN. It doesn't happen using the file dialog, and it doesn't happen with FFN on ST2. Any time the panel is auto closed, such as when keep_panel_open_after_action is false, the cursor is gone and typing does nothing until you click somewhere.
jsc
 
Posts: 23
Joined: Wed Feb 20, 2013 2:24 am

Re: ST3: FuzzyFileNav

Postby facelessuser on Mon Feb 25, 2013 12:38 am

Try it now. Let me know if there are other odd quirks you stumble on.
facelessuser
 
Posts: 1575
Joined: Tue Apr 05, 2011 7:38 pm

Re: ST3: FuzzyFileNav

Postby jsc on Mon Feb 25, 2013 1:23 am

That seems to have fixed it.
jsc
 
Posts: 23
Joined: Wed Feb 20, 2013 2:24 am

Re: ST3: FuzzyFileNav

Postby jsc on Mon Feb 25, 2013 5:07 am

Another feature request: have make new file and make new directory recognize a slash or a backslash and create any necessary intermediate folders instead of saying it can't be done.
jsc
 
Posts: 23
Joined: Wed Feb 20, 2013 2:24 am

PreviousNext

Return to Plugin Announcements

Who is online

Users browsing this forum: No registered users and 20 guests