Home Download Buy Blog Forum Support

(osx|windows|linux) Color Scheme Editor (BETA)

Re: (osx|windows|linux) Color Scheme Editor (BETA)

Postby facelessuser on Tue Nov 05, 2013 12:55 am

I will be honest. All new plugins that I am doing, I code from an ST3 perspective. I code for what I use, and I am using ST3. Many of my plugins that originally were supported on ST2, I have continued to back-port features and fixes to the separate legacy branches, but that will only be until ST3 is released. I won't kill them off, but new features I will leave to others to back-port if they are desired. I have a bunch of plugins right now, and supporting them all for multiple platforms is a bit of work. Most of my new plugins have been ST3 only: RawLineEdit, QuickCal, EasyDiff, etc. Maybe I will make some donate buttons very prominent on some of my projects and see which ones people actually support the most. Maybe those I will support in the long term for ST2.

As for the plugin at hand:
  • Using a real thread would fix that issue for sure; I almost did use a real thread, and I don't mind switching to a real thread either (it really isn't that much extra work to use real threads), but I took the path of least resistance last night to get the proof of concept out (and I wanted to try out `set_timeout_async` because I hadn't as of yet).
  • Also, I would need to abstract the requests for package resources.
  • I think I would need to abstract some unicode stuff as well...pretty sure, there always seems to be some kind of unicode conflicts :)

I am not adverse to supporting this on ST2 and ST3 as a single branch. The tool itself already works regardless of platform (that is really 90% of the work). I imagine that once the plugin supports both, it really wouldn't require much maintenance since its main purpose is to call the tool.

If you are feeling ambitious, I would gladly welcome help on getting it ST2 compatible. If not, I will take a look when I get some time. I will at least look at the threading issue tonight; I did take the easy way out on that one :).

It is always hard for me to gauge how much real excitement there is for a plugin, so it also makes it hard for me to gauge how much effort to put in, so I always code for myself first and then others as my motivation allows.

Edit: If I am feeling ambitious tonight, I will see how far I can get with ST2 abstraction.
facelessuser
 
Posts: 1575
Joined: Tue Apr 05, 2011 7:38 pm

Re: (osx|windows|linux) Color Scheme Editor (BETA)

Postby facelessuser on Tue Nov 05, 2013 3:43 am

Now using the threading library.

Edit: I was wrong about the message dialogs. ST2 supports OK/Cancel dialogs.
Last edited by facelessuser on Tue Nov 05, 2013 7:35 am, edited 1 time in total.
facelessuser
 
Posts: 1575
Joined: Tue Apr 05, 2011 7:38 pm

Re: (osx|windows|linux) Color Scheme Editor (BETA)

Postby facelessuser on Tue Nov 05, 2013 7:29 am

pc-compatible branch now should handle ST2 or ST3. I have not tested it on windows yet, so there may be some file path issues. I will test it tomorrow when I get to a windows machine. It does appear to work on OSX though.
facelessuser
 
Posts: 1575
Joined: Tue Apr 05, 2011 7:38 pm

Re: (osx|windows|linux) Color Scheme Editor (BETA)

Postby facelessuser on Tue Nov 05, 2013 2:41 pm

Small fix for windows now posted. Turns out opening a dialog in as a plugin is loading on ST2 on windows can cause sublime not to start. So a delay has been added before checking and prompting if a download is desired.

Good news is this works on ST2 and ST3 and has been verified on Windows and OSX now.
facelessuser
 
Posts: 1575
Joined: Tue Apr 05, 2011 7:38 pm

Re: (osx|windows|linux) Color Scheme Editor (BETA)

Postby FichteFoll on Thu Nov 07, 2013 1:09 am

I'm sorry that I couldn't take a look at it yesterday but I'm really busy atm and the spare time I get is spent in other ways than coding, even though I would love to. I'm hoping to look at it on the weekend but my workload is huge. (And it certainly doesn't help that I'm continously adding more stuff to it, even though it increases less than before.)
FichteFoll
 
Posts: 388
Joined: Fri Mar 16, 2012 11:49 pm
Location: Germany

Re: (osx|windows|linux) Color Scheme Editor (BETA)

Postby facelessuser on Thu Nov 07, 2013 3:50 am

FichteFoll wrote:I'm sorry that I couldn't take a look at it yesterday but I'm really busy atm and the spare time I get is spent in other ways than coding, even though I would love to. I'm hoping to look at it on the weekend but my workload is huge. (And it certainly doesn't help that I'm continously adding more stuff to it, even though it increases less than before.)


No worries. Get to it when you can. I understand busy, it is the same reason why I have issues on my repos that have been open for months, it is also why this project hasn't seen any recent development until now. I've been dragging my feet on completing this project for a while.
facelessuser
 
Posts: 1575
Joined: Tue Apr 05, 2011 7:38 pm

Re: (osx|windows|linux) Color Scheme Editor (BETA)

Postby rgidney on Sun Nov 10, 2013 7:32 pm

I tried in both st2 and st3 on Windows 7, have not tried OS X 10.9 or Windows 8 yet. I can apply changes to a theme but not save. When I do a save as it creates a monochrome theme.

When I use the 0.8 binary I have no issues and can save and save as though save as still creates a monochrome theme.

Bruce
rgidney
 
Posts: 26
Joined: Wed Feb 29, 2012 11:58 am

Re: (osx|windows|linux) Color Scheme Editor (BETA)

Postby facelessuser on Sun Nov 10, 2013 11:46 pm

rgidney wrote:I tried in both st2 and st3 on Windows 7, have not tried OS X 10.9 or Windows 8 yet. I can apply changes to a theme but not save. When I do a save as it creates a monochrome theme.

When I use the 0.8 binary I have no issues and can save and save as though save as still creates a monochrome theme.

Oh...wow. Hah, looks like a broke some stuff along the way. The monochrome theme is a default one that gets created when you don't give it a theme. For some reason, I am dumping that during save as...I need to fix that. Thanks for the report! I don't do a lot of save as, I mainly use the edit current theme, and watch my changes update there (by default it live edits a copy of the theme that it copies over to User/ColorSchemeEditorTemp). I don't know if many people have been using this app, so development kind of slowed on this. I can get this fixed this week though.

OSX 10.9 appears to have an issue where it isn't showing the menu bar items. Apparently there were some changes to Cocoa...I will play around and see if there is an obvious fix. I don't know if recompiling on OSX 10.9 will make a difference.

I have plans to update some stuff for a 0.9 version. I will fix save as and post when it is finished.
facelessuser
 
Posts: 1575
Joined: Tue Apr 05, 2011 7:38 pm

Re: (osx|windows|linux) Color Scheme Editor (BETA)

Postby facelessuser on Mon Nov 11, 2013 12:56 am

Found the save as bug, it was sloppy on my part. But 0.0.9 will have it fixed. I will more thoroughly test the next one :).

Still confused about OSX and wxpython on 10.9. No menu bar... :(

Edit: Menu bar appears after selecting a different window and reselecting the app. Will probably be fixed in a new WxPython...but we will just have to wait for that ...oh well. Everything else is moving forward.
facelessuser
 
Posts: 1575
Joined: Tue Apr 05, 2011 7:38 pm

Re: (osx|windows|linux) Color Scheme Editor (BETA)

Postby rgidney on Tue Nov 12, 2013 12:14 pm

After some more testing in Windows 7 and 10.9 I found if I open subclrschm inside of sublime I can not save changes (save grayed out), only save as but if I open it out side of sublime then save is available, after making a change.

I tried running subclrschm with sublime open and with it closed and the behavior was the same, it was only when it was called from sublime that save is inactive.
rgidney
 
Posts: 26
Joined: Wed Feb 29, 2012 11:58 am

PreviousNext

Return to Plugin Announcements

Who is online

Users browsing this forum: Google [Bot] and 8 guests